Skip to content

[dotnet] Adjust test to utilize correct exception when authenticator was removed #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nvborisenko wants to merge 1 commit into from
Closed

[dotnet] Adjust test to utilize correct exception when authenticator was removed #2157

nvborisenko wants to merge 1 commit into from

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Jan 31, 2025 •
edited by qodo-code-review bot
Loading

User description

Description

Adjust test.

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Tests, Bug fix

Description

  • Updated test to use the correct exception type.

  • Ensured compatibility with authenticator removal operations.

Changes walkthrough 📝

Relevant files
Tests
VirtualAuthenticatorTest.cs
Update test to assert correct exception type                         

examples/dotnet/SeleniumDocs/Interactions/VirtualAuthenticatorTest.cs

  • Changed exception type in test assertion.
  • Replaced WebDriverArgumentException with InvalidOperationException.
    		• +1/-1     
    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
    •

    @netlify
    Copy link

    netlify bot commented Jan 31, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit ee836a5

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Jan 31, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link
    Contributor

    qodo-code-review bot commented Jan 31, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Verify removal before testing operations

    Add a verification step before the assertion to ensure the authenticator was
    actually removed by checking if the virtualAuthenticatorId is no longer valid.

    examples/dotnet/SeleniumDocs/Interactions/VirtualAuthenticatorTest.cs [86-89]

     ((WebDriver)driver).RemoveVirtualAuthenticator(virtualAuthenticatorId);
 
-// Since the authenticator was removed, any operation using it will throw an error
+// Verify authenticator was removed
+Assert.ThrowsException<InvalidOperationException>(() => ((WebDriver)driver).GetAuthenticatorId(virtualAuthenticatorId));
+// Verify operations fail
 Assert.ThrowsException<InvalidOperationException>(() => ((WebDriver)driver).GetCredentials());
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion improves test reliability by adding a verification step to explicitly confirm the authenticator removal before testing subsequent operations. This makes the test more robust and helps identify the exact point of failure.

    		7

    @nvborisenko nvborisenko requested a review from pujagani January 31, 2025 14:45
    @nvborisenko
    Copy link
    Member Author

    nvborisenko commented Feb 7, 2025

    Thanks, obsolete, fixed in trunk.

    @nvborisenko nvborisenko closed this Feb 7, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @pujagani pujagani Awaiting requested review from pujagani

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    @nvborisenko